fix function estimate_memory_usage() function #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults for both vector and map storages
DrDet
force-pushed
the
seismont/fix-estimate-memory-usage
branch
2 times, most recently
from
08e1ce1
to
967945c
Compare
DrDet
added
runtime
DrDet
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
estimate_memory_usage()function shows incorrect results for both vector and map internal storage.It actually shows how much memory is needed for copying this array, rather than how much memory it currently takes. So it takes only
sizeto calculate the memory amount and ignorescapacity.This logic is used in
InstanceDeepCopyVisitorto check if it will be enough memory for copying beforehand. So in this PR this logic is extracted to separate functioncalculate_memory_for_copying.And
estimate_memory_usagefor arrays now returns the correct size based oncapacity.